Add condition token filter docs #7923 #7950
Conversation
Signed-off-by: AntonEliatra <[email protected]>
AntonEliatra
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@udabhas Could you review this PR for technical accuracy? |
|
@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you. |
Signed-off-by: AntonEliatra <[email protected]>
@varun-lodaya This is over a month old. We need tech review approval to move it forward in the documentation process. Please review this week or provide a peer who can review it. Thank you. |
Signed-off-by: Anton Rubin <[email protected]>
There was a problem hiding this comment.
Looks good to me.
nit: I think it would be good to state explicitly that only INLINE scripts are accepted. Also link to scripting in opensearch - https://opensearch.org/docs/latest/api-reference/script-apis/exec-script/
Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
|
I've added inline script explanation as recommended |
There was a problem hiding this comment.
Thank you, @AntonEliatra! A couple of changes and a question before we move this to editorial review.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
|
@kolchfa-aws to answer the question, no, this is not case sensitive, I updated to "um" instead. |
There was a problem hiding this comment.
@AntonEliatra @kolchfa-aws Please see my changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
* adding condition token filter docs #7923 Signed-off-by: AntonEliatra <[email protected]> * Update condition.md Signed-off-by: AntonEliatra <[email protected]> * updating parameter table Signed-off-by: Anton Rubin <[email protected]> * addressing PR comments Signed-off-by: Anton Rubin <[email protected]> * addressing PR comments Signed-off-by: Anton Rubin <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Update condition.md Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: Anton Rubin <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 8b64855) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…roject#7950) * adding condition token filter docs opensearch-project#7923 Signed-off-by: AntonEliatra <[email protected]> * Update condition.md Signed-off-by: AntonEliatra <[email protected]> * updating parameter table Signed-off-by: Anton Rubin <[email protected]> * addressing PR comments Signed-off-by: Anton Rubin <[email protected]> * addressing PR comments Signed-off-by: Anton Rubin <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: AntonEliatra <[email protected]> * Update condition.md Signed-off-by: AntonEliatra <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: AntonEliatra <[email protected]> --------- Signed-off-by: AntonEliatra <[email protected]> Signed-off-by: Anton Rubin <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
Description
Add condition token filter docs
Issues Resolved
Part of #7923
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.